Skip to content

fix(iOS): modal becomes unresponsive with refresh control inside scrollable #48580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kkafar wants to merge 1 commit into from
Closed

fix(iOS): modal becomes unresponsive with refresh control inside scrollable #48580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...tive/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,9 @@ - (void)didMoveToWindow
{
[super didMoveToWindow];
if (self.window) {
[self _attach];
dispatch_async(dispatch_get_main_queue(), ^{
Copy link
Contributor

@cipolleschi cipolleschi Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use RCTExecuteOnMainQueue instead? It avoids the jump if we are already on the main queue.

Copy link
Contributor Author

@kkafar kkafar Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all about placing the block at the end of the queue - see my response here: #48580 (comment)

[self _attach];
});
} else {
[self _detach];
Copy link
Contributor

@cipolleschi cipolleschi Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we add the same in the detach? also, how come that didMoveToWindow is called in a queue that is not the main queue? These methods are called by UIKit, React Native is not calling them explicitly...

Copy link
Contributor Author

@kkafar kkafar Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice any problems with detach behaviour therefore I've left the code intact.

I believe this is a timing issue rather. The method is executed on UI thread as expected. See below

}
Expand Down
Loading