Share logic in BaseTextInputShadowNode to calculate placeholder string #48584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68004218 |
…putShadowNode for Android (facebook#48582) Summary: [Changelog] [Internal] - Preparation for sharing common ShadowNode functionality in BaseTextInputShadowNode for Android As a preparation for facebook#48165 this change aligns the order of methods between: - BaseTextInputShadowNode.h - AndroidTextInputShadowNode.h to make it easier for future changes to look at the delta between both implementations. The goal is land facebook#48582 which aligns the RN iOS and RN Android implementation Differential Revision: D68001423
…g with AndroidTextInputShadowNode (facebook#48584) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to calculate placeholder string with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004218
christophpurrer
force-pushed
the
export-D68004218
branch
from
45e9205 to
9a5ca1d
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…g with AndroidTextInputShadowNode (facebook#48584) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to calculate placeholder string with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004218
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68004218 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…lder string with AndroidTextInputShadowNode (facebook#48584) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to calculate placeholder string with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004218
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…g with AndroidTextInputShadowNode (facebook#48584) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to calculate placeholder string with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004218
Contributor
|
This pull request has been merged in 55d0bc4. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in 55d0bc4 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As a preparation for #48165 this change aligns the order of methods between:
Differential Revision: D68004218