Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode #48585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68004755 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
force-pushed
the
export-D68004755
branch
from
7d54a21 to
e0bee1a
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 15, 2025
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68004755 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 15, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 15, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
force-pushed
the
export-D68004755
branch
from
e0bee1a to
6411ed7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 16, 2025
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 16, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68004755 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 16, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
force-pushed
the
export-D68004755
branch
from
6411ed7 to
818cdc4
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68004755 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
christophpurrer
force-pushed
the
export-D68004755
branch
from
818cdc4 to
ba69fad
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68004755 |
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
christophpurrer
force-pushed
the
export-D68004755
branch
from
ba69fad to
4ae8d36
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68004755 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
Collaborator
|
This pull request was successfully merged by @christophpurrer in 1498566 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in 1498566. |
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: Pull Request resolved: facebook#48585 [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755 fbshipit-source-id: 519247de0d081f37b5ef8ad6093b43d2c735a50e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode
As a preparation for #48165 this aligns the implementation of those 2 methods
Differential Revision: D68004755