Implement prop diffing for border props in <View>#48831
Closed
mdvacca wants to merge 4 commits intofacebook:mainfrom
Closed
Implement prop diffing for border props in <View>#48831mdvacca wants to merge 4 commits intofacebook:mainfrom
mdvacca wants to merge 4 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59972037 |
mdvacca
force-pushed
the
export-D59972037
branch
from
32677e7 to
0742e88
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59972037 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
…#48831) Summary: This diff implements the diffing for border props of <View> changelog: [internal] internal Differential Revision: D59972037
mdvacca
force-pushed
the
export-D59972037
branch
from
0742e88 to
a76a54f
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
Summary: This diff implements the diffing for border props of <View> changelog: [internal] internal Differential Revision: D59972037
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
…#48831) Summary: This diff implements the diffing for border props of <View> changelog: [internal] internal Differential Revision: D59972037
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59972037 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
…#48831) Summary: This diff implements the diffing for border props of <View> changelog: [internal] internal Differential Revision: D59972037
Summary: In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328
…48829) Summary: This diff implements the diffing for basic props of <View> changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59972040
…48830) Summary: This diff implements the diffing for event props of <View> changelog: [internal] internal Reviewed By: javache Differential Revision: D59972038
Summary: This diff implements the diffing for border props of <View> changelog: [internal] internal Reviewed By: sammy-SC Differential Revision: D59972037
mdvacca
force-pushed
the
export-D59972037
branch
from
a76a54f to
28bcaa4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59972037 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
…#48831) Summary: This diff implements the diffing for border props of <View> changelog: [internal] internal Reviewed By: sammy-SC Differential Revision: D59972037
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
…#48831) Summary: This diff implements the diffing for border props of <View> changelog: [internal] internal Reviewed By: sammy-SC Differential Revision: D59972037
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
…#48831) Summary: This diff implements the diffing for border props of <View> changelog: [internal] internal Reviewed By: sammy-SC Differential Revision: D59972037
Contributor
|
This pull request has been merged in 9a5e365. |
This was referenced May 27, 2025
Closed
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: facebook#48831 This diff implements the diffing for border props of <View> changelog: [internal] internal Reviewed By: sammy-SC Differential Revision: D59972037 fbshipit-source-id: b93a0962616222686a4340cd1e7f2943bd3bc140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff implements the diffing for border props of
changelog: [internal] internal
Differential Revision: D59972037