fix(react-native): pass the protocol from bundle URL to HMR client on Android

[byCedric]

Summary:

This is another attempt at fixing the Android HMR client for HTTPS proxied Metro instances. The previous one unintentionally caused the following error:

java.lang.AssertionError: Method overloading is unsupported: com.facebook.react.devsupport.HMRClient#setup

This PR removes the overloading, and only adds the scheme property as a parameter to the existing .setup method. Aligning with the exact behavior we have on iOS.

The alternative fix, which should NOT be backward breaking (if this is) - is to move this "infer the protocol from the bundle URL" to the JS side of the HMR client. Where we don't just always default to http, but instead default to https IF port === 443, otherwise http. It's a bit more hacky, but shouldn't cause any other issues. Ideally, we have the same working behavior on both Android and iOS without workarounds.

Alternative workaround

See this change.

See full explanation on #48970

We've noticed that the HMR on Android doesn't seem to be connecting when using a HTTPS-proxied Metro instance, where the proxy is hosted through Cloudflare. This is only an issue on Android - not iOS - and likely caused by the HMR Client not being set up properly on Android.

• On Android, we run .setup('android', <bundleEntryPath>, <proxiedMetroHost>, <proxiedMetroPort>, <hmrEnabled>) in the react/devsupport/DevSupportManagerBase.java file.
• On iOS, we run [self.callableJSModules invokeModule:@"HMRClient" method:@"setup" withArgs:@[ RCTPlatformName, path, host, RCTNullIfNil(port), @(isHotLoadingEnabled), scheme ]]; in the React/CoreModules
  /RCTDevSettings.mm file.

Notice how Android does not pass in the scheme/protocol of the bundle URL, while iOS actually does? Unfortunately, because the default protocol (http) mismatches on Android when using HTTPS proxies, we actually try to connect the HMR client over http instead of https - while still using port 443 - which is rejected by Cloudflare's infrastructure even before we can redirect or mitigate this issue. And the rejection is valid, as we basically try to connect on http://<host>:443 (the source URL is https, so the port is infered as 443).

This change adds scheme propagation to Android, exactly like we do on iOS for the HMR Client.

Changelog:

[ANDROID] [FIXED] Pass the bundle URL protocol when setting up HMR client on Android

Test Plan:

See full explanation on #48970

It's a little bit hard to test this out yourself, since you'd need a HTTPS-based proxy and reject HTTP connections for HTTPS/WSS Websocket requests.

You can set this up through:

• bun create expo@latest ./test-app
• cd ./test-app
• touch .env
• Set EXPO_PACKAGER_PROXY_URL=https://<proxied-metro-hostname> in .env
• Set REACT_NATIVE_PACKAGER_HOSTNAME=<proxied-metro-hostname> in .env
• bun run start

Setting both these envvars, the bundle URL in the manifest is set to https://... - which triggers this HMR issue on Android. You can validate the .env setup through:

curl "http://localhost:8081" -H "expo-platform: android" | jq .launchAsset.url

This should point the entry bundle URL towards the EXPO_PACKAGER_PROXY_URL.

[facebook-github-bot]

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@javache merged this pull request in 32fe244.

[react-native-bot]

This pull request was successfully merged by @byCedric in 32fe244

^{When will my fix make it into a release? | How to file a pick request?}

[react-native-bot]

This pull request was successfully merged by @byCedric in 1bd9d36

^{When will my fix make it into a release? | How to file a pick request?}

[react-native-bot]

This pull request was successfully merged by @byCedric in 68055f2

^{When will my fix make it into a release? | How to file a pick request?}