Undo breaking change in ReactPointerEventsView due to Kotlin conversion#49233
Closed
cortinico wants to merge 1 commit intofacebook:mainfrom
Closed
Undo breaking change in ReactPointerEventsView due to Kotlin conversion#49233cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: I'm converting the function inside ReactPointerEventsView from `fun` to `val`. This Kotlin conversion resulted in a breakign change for Kotlin consumer which I believe can be prevented if we do this change instead. Changelog: [Internal] [Changed] - Differential Revision: D69252562
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69252562 |
Contributor
|
This pull request has been merged in 5a4962a. |
Collaborator
|
This pull request was successfully merged by @cortinico in 5a4962a When will my fix make it into a release? | How to file a pick request? |
fabriziocucci
pushed a commit
that referenced
this pull request
Feb 10, 2025
…on (#49233) Summary: Pull Request resolved: #49233 I'm converting the function inside ReactPointerEventsView from `fun` to `val`. This Kotlin conversion resulted in a breakign change for Kotlin consumer which I believe can be prevented if we do this change instead. Changelog: [Internal] [Changed] - Reviewed By: alanleedev Differential Revision: D69252562 fbshipit-source-id: b277c6720f3156ed532bf5f2253d54cd72e38050
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
…on (facebook#49233) Summary: Pull Request resolved: facebook#49233 I'm converting the function inside ReactPointerEventsView from `fun` to `val`. This Kotlin conversion resulted in a breakign change for Kotlin consumer which I believe can be prevented if we do this change instead. Changelog: [Internal] [Changed] - Reviewed By: alanleedev Differential Revision: D69252562 fbshipit-source-id: b277c6720f3156ed532bf5f2253d54cd72e38050
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I'm converting the function inside ReactPointerEventsView from
funtoval.This Kotlin conversion resulted in a breakign change for Kotlin consumer which I believe can be prevented
if we do this change instead.
Changelog:
[Internal] [Changed] -
Differential Revision: D69252562