fix: correctly forward dependency on @react-native-community/cli-server-api

[tido64]

Summary:

@react-native/community-cli-plugin depends on @react-native-community/cli-server-api but incorrectly declares it as optional. When the dependency is not found, the bundle and start commands are not registered. This change removes the optional flag and forwards the dependency to consumers of react-native.

Resolves #47309

Changelog:

[GENERAL] [FIXED] - Fix @react-native-community/cli-server-api not being found under certain hoisting conditions

Test Plan:

See #47309 for repro steps.

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cortinico]

@tido64 @robhogan
mentioned that this will force cli-server-api to be installed (or at least result in a warning) also for expo users.

Can't we add this as direct dependency inside the template instead?

[tido64]

We still need it here for it to be hoisted correctly. But we can make it optional and make it a direct dependency in the template.

Edit: I meant to submit a PR to the template but got distracted. Will try to get to it later tonight.

[cortinico]

We still need it here for it to be hoisted correctly

Why do we need it here specifically?

[tido64]

Basically, we declare that @react-native/community-cli-plugin depends on cli-server-api but that consumers need to satisfy this requirement. The only consumer of @react-native/community-cli-plugin is react-native, but you don't want react-native to depend on CLI any longer. So react-native needs to "forward" the dependency to its consumers, hence redeclare peer dependency. Without this, package managers won't correctly link the package.

However, since react-native has cli-server-api as peer dependency, it's probably fine to mark it as optional and add it in the template as a direct dependency to satisfy the requirement.

[tido64]

react-native-community/template#105

[cortinico]

but you don't want react-native to depend on CLI any longer.

I think there is some cleanup to make sure react-native doesn't need to depend on @react-native/community-cli-plugin at all so this change wont' be required at all

[tido64]

I think there is some cleanup to make sure react-native doesn't need to depend on @react-native/community-cli-plugin at all so this change wont' be required at all

Yes, that would be the proper solution in the long run.

[cortinico]

For the time being, can't we just have:

1. Remove the peerDependency here between react-native and @react-native-community/cli-server-api (so amend this line)
2. Add the dependency on the template as per fix: @react-native/community-cli-plugin depends on @react-native-community/cli-server-api react-native-community/template#105

?

[tido64]

I've replied to this offline but I'll post it here as well for transparency: The short answer is, if you do it this way, package managers won't put @react-native-community/cli-server-api in a place where @react-native/community-cli-plugin will be able to find it.

Longer answer: See #49325 (comment)