chore: add jest-config to monorepo dependencies#50280
Closed
Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Closed
chore: add jest-config to monorepo dependencies#50280Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Contributor
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @Saadnajmi in 4789744 When will my fix make it into a release? | How to file a pick request? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The React Native monorepo depends on
jest-configinjest.config.jsbut does not specify it as a dependency. This means we got it as a phantom / transitive dependency. In React Native macOS, I am testing using Yarn 4 with pnpm layout to protect against such dependencies (See microsoft#2366). The simplest way to fix this is to just declare it as a dependency.Changelog:
[INTERNAL] [FIXED] - Add jest-config as a dependency
Test Plan:
This change should be a no-op in React Native, we already had the package in our lock.