Platform specific TextLayoutManager Headers #50889

NickGerleman · 2025-04-24T01:22:31Z

Summary:
This effectively reverts D67064488

We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, #ifdef ANDROID may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably).

For Facsimile, we are going to be introducing more potential divergence, with the idea of PreparedText, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere.

I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messieness, then allow shared code (e.g. in ParagraphShadowNode) to pick how to interact at compile time. I added an example of this as part of TextLayoutManagerTraits, to customize how we act if a TextLayoutManager chooses not to implement measureLines.

Changelog: [Internal]

Differential Revision: D73557126

facebook-github-bot · 2025-04-24T01:22:53Z

This pull request was exported from Phabricator. Differential Revision: D73557126

facebook-github-bot · 2025-04-24T21:29:13Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messieness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerTraits`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-24T21:38:03Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messieness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerTraits`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-24T21:45:13Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messieness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerTraits`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-24T22:07:58Z

This pull request was exported from Phabricator. Differential Revision: D73557126

facebook-github-bot · 2025-04-25T00:24:01Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messiness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerTraits`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-25T22:27:41Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messiness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerTraits`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-26T00:32:46Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messiness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerExtended`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-26T00:38:36Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messiness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerExtended`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-26T00:44:06Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messiness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerExtended`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-26T00:50:13Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messiness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerExtended`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-26T00:58:12Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messiness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerExtended`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-26T01:03:02Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messiness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerExtended`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-26T01:10:25Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messiness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerExtended`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-26T01:16:25Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messiness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerExtended`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Differential Revision: D73557126

facebook-github-bot · 2025-04-29T21:32:59Z

This pull request was exported from Phabricator. Differential Revision: D73557126

Summary: Pull Request resolved: facebook#50889 This effectively reverts D67064488 We are trying to smash together functions, variables, virtual or non-virtual, all required by different platforms, into a single header, often using #ifdefs that are not what we want (apart from a bad editor experience, `#ifdef ANDROID` may or may not be compiled into the react-native-cxx platform, and we cannot use it for the Android platform reliably). For Facsimile, we are going to be introducing more potential divergence, with the idea of `PreparedText`, where we can generate intermediate products as part of the layout process to be reused later. I'm planning to design that in a way which can be eventually reused across platforms, but not everywhere. I think the best path for this is going to be to allow each platform to have their own headers, instead of the current messiness, then allow shared code (e.g. in `ParagraphShadowNode`) to pick how to interact at compile time. I added an example of this as part of `TextLayoutManagerExtended`, to customize how we act if a `TextLayoutManager` chooses not to implement `measureLines`. Changelog: [Internal] Reviewed By: rshest Differential Revision: D73557126

facebook-github-bot · 2025-04-29T21:40:04Z

This pull request was exported from Phabricator. Differential Revision: D73557126

facebook-github-bot · 2025-04-30T01:49:41Z

This pull request has been merged in 2e42eab.

react-native-bot · 2025-04-30T01:49:46Z

This pull request was successfully merged by @NickGerleman in 2e42eab

^{When will my fix make it into a release? | How to file a pick request?}

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 24, 2025

facebook-github-bot added the fb-exported label Apr 24, 2025

NickGerleman force-pushed the export-D73557126 branch from e46d624 to b81496b Compare April 24, 2025 21:29

NickGerleman force-pushed the export-D73557126 branch from b81496b to 6a7da02 Compare April 24, 2025 21:38

NickGerleman force-pushed the export-D73557126 branch from 6a7da02 to 961dcf0 Compare April 24, 2025 21:45

NickGerleman force-pushed the export-D73557126 branch from b8dc44d to 50f3018 Compare April 25, 2025 00:24

NickGerleman force-pushed the export-D73557126 branch from 50f3018 to 8f35f44 Compare April 25, 2025 22:28

NickGerleman force-pushed the export-D73557126 branch from 8f35f44 to 09551e3 Compare April 26, 2025 00:33

NickGerleman force-pushed the export-D73557126 branch from 09551e3 to c30b99c Compare April 26, 2025 00:39

NickGerleman force-pushed the export-D73557126 branch from c30b99c to c8af7a7 Compare April 26, 2025 00:44

NickGerleman force-pushed the export-D73557126 branch from c8af7a7 to 6297f9a Compare April 26, 2025 00:51

NickGerleman force-pushed the export-D73557126 branch from 6297f9a to 03c5aac Compare April 26, 2025 00:58

NickGerleman force-pushed the export-D73557126 branch from 03c5aac to 5bada15 Compare April 26, 2025 01:03

NickGerleman force-pushed the export-D73557126 branch from 5bada15 to 3a93ead Compare April 26, 2025 01:10

NickGerleman force-pushed the export-D73557126 branch from 3a93ead to 0808bba Compare April 26, 2025 01:16

NickGerleman force-pushed the export-D73557126 branch from 0808bba to a343933 Compare April 29, 2025 21:33

NickGerleman force-pushed the export-D73557126 branch from a343933 to 4bef384 Compare April 29, 2025 21:40

facebook-github-bot closed this in 2e42eab Apr 30, 2025

facebook-github-bot added the Merged This PR has been merged. label Apr 30, 2025

anupriya13 mentioned this pull request Jul 24, 2025

Integrate RN Nightly Build 0.80.0-nightly-20250506-3ac16dd6a microsoft/react-native-windows#14951

Merged

Platform specific TextLayoutManager Headers #50889

Platform specific TextLayoutManager Headers #50889

Uh oh!

Conversation

NickGerleman commented Apr 24, 2025

Uh oh!

facebook-github-bot commented Apr 24, 2025

Uh oh!

facebook-github-bot commented Apr 24, 2025

Uh oh!

facebook-github-bot commented Apr 24, 2025

Uh oh!

facebook-github-bot commented Apr 24, 2025

Uh oh!

facebook-github-bot commented Apr 24, 2025

Uh oh!

facebook-github-bot commented Apr 25, 2025

Uh oh!

facebook-github-bot commented Apr 25, 2025

Uh oh!

facebook-github-bot commented Apr 26, 2025

Uh oh!

facebook-github-bot commented Apr 26, 2025

Uh oh!

facebook-github-bot commented Apr 26, 2025

Uh oh!

facebook-github-bot commented Apr 26, 2025

Uh oh!

facebook-github-bot commented Apr 26, 2025

Uh oh!

facebook-github-bot commented Apr 26, 2025

Uh oh!

facebook-github-bot commented Apr 26, 2025

Uh oh!

facebook-github-bot commented Apr 26, 2025

Uh oh!

facebook-github-bot commented Apr 29, 2025

Uh oh!

facebook-github-bot commented Apr 29, 2025

Uh oh!

facebook-github-bot commented Apr 30, 2025

Uh oh!

react-native-bot commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants