Added example implementation for Android <Portal> per #2501#5264
Added example implementation for Android <Portal> per #2501#5264niftylettuce wants to merge 1 commit intofacebook:masterfrom niftylettuce:master
<Portal> per #2501#5264Conversation
|
By analyzing the blame information on this pull request, we identified @vjeux, @mkonicek and @brentvatne to be potential reviewers. |
|
We've been discussing whether to keep the portal implementation or ship a native module for showing modals instead. In the Ads Manager we currently use the Portal to implement modals (https://gist.github.com/mkonicek/1a45b8f8c36bb710478c) but might deprecate that actually. Would you mind holding with this until it's clear whether we'll go with the native module? |
|
@mkonicek are you asking me? I think this should be accepted as a PR or a decision should be made ASAP, there needs to be native modal support on Android. |
|
The decision is we'd like to go with the native module to implement I agree we should clear out the list of missing Android modules as quickly as we can: https://facebook.github.io/react-native/docs/known-issues.html, a few releases from now it should be gone except for push notifications for which we only have an implementation very tied to the fb infra and using it in the Ads Manager on Android. |
|
@niftylettuce updated the pull request. |
|
@mkonicek We should probably document since Modal is not going to be ready anytime soon. |
No description provided.