Enable fixTextClippingAndroid15useBoundsForWidth in Experimental
#54799
+98
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebook#54721) Summary: Android 15 (API 35) changed TextView's default behavior to use visual glyph bounds for width calculation (useBoundsForWidth=true). This causes text clipping for italic fonts and other typefaces where glyphs extend beyond their advance width: https://developer.android.com/about/versions/15/behavior-changes-15 This PR uses a two-pass layout approach on Android 15+: 1. Create an unconstrained layout with setUseBoundsForWidth(true) to measure the actual visual bounds width 2. Create the final layout using the visual bounds width as layoutWidth This ensures the container is sized correctly to accommodate the full visual extent of the text, preventing clipping while maintaining backwards compatibility with earlier Android versions. Performance impact: - On Android 14 and below: No change - On Android 15+: Creates two StaticLayout instances instead of one for text with unconstrained or AT_MOST width. This overhead is mitigated by React Native's text measurement caching in the C++ layer, which avoids redundant measurements. Text with EXACTLY width mode is unaffected as it only requires a single layout pass. Closes facebook#53286 Thanks a lot to intergalacticspacehighway for finding the root cause and creating a proof of concept fix. ## Changelog: [ANDROID] [FIXED] - Fix text clipping on Android 15+ due to useBoundsForWidth change Pull Request resolved: facebook#54721 Test Plan: Run the tests from facebook#53286 to verify. **Images from original issue:** <img width="800" alt="image" src="https://github.com/user-attachments/assets/db6fa569-f6d6-4526-90ff-a3d71bfbb7c6" /> **With fix (with some additional text spans for testing):** _Android 16_ <img width="220" alt="image" src="https://github.com/user-attachments/assets/43b7e648-a38f-4100-9186-a4efa14e3e04" /> _Android Pre 15_ <img width="220" alt="image" src="https://github.com/user-attachments/assets/75fb34cd-2455-439b-a12d-a2c15577008c" /> Reviewed By: javache Differential Revision: D88001642 Pulled By: cortinico
Summary: This enables the `fixTextClippingAndroid15useBoundsForWidth` for experimetnal builds of React Native. Differential Revision: D88487332
meta-cla
bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88487332. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This enables the
fixTextClippingAndroid15useBoundsForWidthfor experimetnalbuilds of React Native.
Differential Revision: D88487332