Add header_mappings_dir to React-Fabric.podspec animated subspec#56151
Closed
zoontek wants to merge 1 commit intofacebook:mainfrom
Closed
Add header_mappings_dir to React-Fabric.podspec animated subspec#56151zoontek wants to merge 1 commit intofacebook:mainfrom
zoontek wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
p: Expo
Contributor
|
thanks for fixing it! |
Collaborator
|
This pull request was successfully merged by @zoontek in a357676 When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Mar 30, 2026
) Summary: When building React Native (`0.85.0-rc.5`) core from source (`RCT_USE_PREBUILT_RNCORE=0`), the `React-Fabric/animated` CocoaPods subspec flattens the `event_drivers/` subdirectory headers because `header_mappings_dir` is not set. CocoaPods' `header_dir` without `header_mappings_dir` places all matched headers directly under the specified directory, losing any subdirectory structure. This means `event_drivers/EventAnimationDriver.h` ends up at `react/renderer/animated/EventAnimationDriver.h` instead of `react/renderer/animated/event_drivers/EventAnimationDriver.h`. The `#include` in `NativeAnimatedNodesManager.h` expects the full path with the `event_drivers/` subdirectory, so the build fails with: ``` 'react/renderer/animated/event_drivers/EventAnimationDriver.h' file not found ``` <img width="1512" height="1012" alt="Screenshot 2026-03-19 at 13 54 29" src="https://github.com/user-attachments/assets/49361c39-d48f-494f-ad7a-c9f3e9749a67" /> This doesn't affect prebuilt (`RCT_USE_PREBUILT_RNCORE=1`) builds because the xcframework ships with a VFS overlay that maps headers correctly. The fix adds `header_mappings_dir` to the `animated` subspec in `React-Fabric.podspec`, which tells CocoaPods to preserve the directory structure relative to `react/renderer/animated`. ## Changelog: [IOS] [FIXED] - Fix `EventAnimationDriver.h` not found when building React Native from source due to missing `header_mappings_dir` in `React-Fabric/animated` podspec Pull Request resolved: #56151 Test Plan: 1. Set `RCT_USE_PREBUILT_RNCORE=0` in your Podfile 2. Run `pod install` 3. Build the project — previously fails with `'react/renderer/animated/event_drivers/EventAnimationDriver.h' file not found` 4. With this fix, the build succeeds Reviewed By: sammy-SC Differential Revision: D97295771 Pulled By: zeyap fbshipit-source-id: 945fbdeef1d25cedbec1e5b2d60c5a940da85840
Collaborator
|
This pull request was successfully merged by @zoontek in fc61224 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When building React Native (
0.85.0-rc.5) core from source (RCT_USE_PREBUILT_RNCORE=0), theReact-Fabric/animatedCocoaPods subspec flattens theevent_drivers/subdirectory headers becauseheader_mappings_diris not set.CocoaPods'
header_dirwithoutheader_mappings_dirplaces all matched headers directly under the specified directory, losing any subdirectory structure. This meansevent_drivers/EventAnimationDriver.hends up atreact/renderer/animated/EventAnimationDriver.hinstead ofreact/renderer/animated/event_drivers/EventAnimationDriver.h.The
#includeinNativeAnimatedNodesManager.hexpects the full path with theevent_drivers/subdirectory, so the build fails with:This doesn't affect prebuilt (
RCT_USE_PREBUILT_RNCORE=1) builds because the xcframework ships with a VFS overlay that maps headers correctly.The fix adds
header_mappings_dirto theanimatedsubspec inReact-Fabric.podspec, which tells CocoaPods to preserve the directory structure relative toreact/renderer/animated.Changelog:
[IOS] [FIXED] - Fix
EventAnimationDriver.hnot found when building React Native from source due to missingheader_mappings_dirinReact-Fabric/animatedpodspecTest Plan:
RCT_USE_PREBUILT_RNCORE=0in your Podfilepod install'react/renderer/animated/event_drivers/EventAnimationDriver.h' file not found