Update providesModuleNodeModules option to use new format.#6039
Closed
skevy wants to merge 3 commits intofacebook:masterfrom
Closed
Update providesModuleNodeModules option to use new format.#6039skevy wants to merge 3 commits intofacebook:masterfrom
skevy wants to merge 3 commits intofacebook:masterfrom
Conversation
Contributor
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
@skevy updated the pull request. |
package.json
Outdated
| { name: "fbjs" }, | ||
| { name: "react" }, | ||
| { name: "react-native" }, | ||
| { name: "parse" } |
Contributor
There was a problem hiding this comment.
Should name be in quotes as it's a JSON file?
Contributor
Author
There was a problem hiding this comment.
Of course it should! :)
skevy
force-pushed
the
fix-providesModuleNodeModules
branch
from
ed33d1e to
b827773
Compare
Contributor
|
@skevy updated the pull request. |
Contributor
|
@facebook-github-bot shipit |
Contributor
|
I will hold this until Monday, though |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
Contributor
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Contributor
|
Closing this one as it's superseded by #6346. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates providesModuleNodeModules option to use new format from facebookarchive/node-haste#33.
Supercedes #5985.
Ok to merge when node-haste is updated.
/cc @bestander @cpojer @mkonicek