Consider warning when we get non-bool values for HAS_BOOLEAN_VALUE attributes

[zpao]

I saw a case where somebody was making use of cx to conditionally disable a button (<button disabled={cx({"disabled": this.state.disabled})}/> - clever but not necessary. I think a warning here might prove useful for these.

[syranide]

I humbly disagree, in JavaScript anything is a boolean and many pass around numbers/strings/objects for use as booleans. I'm also feeling hesitant towards the issue itself, we should encourage good practices whenever we can, but there is no programmatic cure for such basic misunderstandings. This is a can of worms IMHO, the warning is likely to be emitted in perfectly valid cases.

[zpao]

Perhaps just strings then? We're lucky that the empty string is falsey, or this could be quite confusing. I don't feel strongly but figured a quick discussion wouldn't be a complete waste of time :)

[syranide]

@zpao I feel like this isn't actionable without throwing a too big net, agree?

[nhunzaker]

No resolution after 2.5 years. Is there anything to move forward on?

[aweary]

I'm going to close this out since there's been no movement, and there's been no indication that this scenario is a common pain point, meaning a warning probably won't be useful enough to justify.