JSX: Whitespace in properties is lost

[zpao]

It looks like we're doing some current position moving incorrectly. @jeffmo, @syranide - do you know if this is something that's getting fixed with the whitespace PR or is this a separate problem?

<Component something="       a bug        " />

becomes

Component( {something:       " a bug "        } )

[zpao]

Play around with different amount of whitespace padding, as well as a whitespace only string. Looks like there are a few edge cases to handle here.

[syranide]

@zpao I have intentionally fixed a few in my whitespace PR (including your example I believe) and I have intentionally not addressed some of them and there are probably a bunch of them that I haven't even come across (didn't look for them).

I think we need to decide on what we actually want in the output, should we try to be as faithful to the source as possible or should we always generate the "correct minimal syntax" loosely speaking?

[sophiebits]

I feel that for attributes we should maintain the original spacing exactly. Line breaks are a small pain but otherwise there's no issue.

[syranide]

@spicyj But what does that actually mean, exactly? :)

<Child.value="5"/>
Child({value:."5"})

<Child..value=."5"./>
Child({.value:.."5".})

?

Intuitively that actually seems kind of ok, if we want to reproduce the source, except I'd do a special-case for the ./>:

<Child..value=."5" />
Child({.value:.."5"})

Also, we want to reproduce line-breaks exactly so that line-numbers match up, but I think my whitespace PR takes care of that (mostly) at least.

[sophiebits]

Sorry, I just meant that the text within the quotes should stay the same.

But I agree that it would be nice if this happened:

<Child.value="5"./>
Child({value:."5"})

Because that's surely the most common way of writing the JSX and corresponding JS by hand.

[syranide]

@spicyj Ah right right, yes my whitespace PR fixes that I'm pretty sure, so what you put inside the quotes is exactly what ends up in the output code.

[plievone]

This seems to be fixed in current master (by #480).

[sophiebits]

This is mostly fixed, though there seems to be some extraneous whitespace in the surrounding JS:

<Component something="       a bug        " />
Component( {something:       "       a bug        "        } )

@syranide do you know if #970 fixes this?

[syranide]

@spicyj That PR should fix 99% of the output weirdness, so yes. :)

[sophiebits]

This is now fixed.