Conversation
acdlite
requested changes
Aug 12, 2017
Collaborator
acdlite
left a comment
acdlite
left a comment
There was a problem hiding this comment.
Make sure you run yarn prettier and commit the result.
| var ReactNativeFiberRenderer = require('ReactNativeFiberRenderer'); | ||
| var {ReactCurrentOwner} = require('ReactGlobalSharedState'); | ||
|
|
||
| var getComponentName = require('getComponentName.js'); |
| 'render, such as refs. Move this logic to componentDidMount and ' + | ||
| 'componentDidUpdate instead.', | ||
| owner.getName() || 'A component', | ||
| getComponentName(owner) |
Collaborator
There was a problem hiding this comment.
This should be
getComponentName(owner) || 'A component',
Contributor
Author
|
@acdlite Done, I forgot that FB prefers trailing |
Contributor
Author
|
@acdlite I think that should cover it. |
Collaborator
|
Thanks! |
Collaborator
|
This is not enough to fix the issue. Please see #10518. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.