Remove Stack (part 2: Stack-only DEV code) #10795
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Oops, I have another candidate for the second step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #10794.
Relevant new commit: d85e22f
This is not safe to land before 16 because it changes the code.
Removes now-dead
ReactComponentTreeHookandReactHostOperationHook,ReactDebugTool,ReactInstrumentation,ReactPerf, and the calls to host operation hook in DOM utilities.In Fiber, we never have a
debugID, so removes the associated codepaths. Also removeson*methods on hooks since in Fiber we callvalidateProperties()directly.Adds empty shims for methods RN still depends on. They are already no-ops, so now we just make this explicit (and add a TODO to remove the dependency). Isn’t it nice to learn this before sync? Yay flat bundles.