Skip to content

Conversation

@gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 24, 2017

Builds on #10794.
New commit is dde565f.

Best diff view is without the whitespace: dde565f?w=1

This removes all useFiber checks in the tests, assuming true. Technically there are no more references to ReactDOMFeatureFlags.useFiber, but I didn’t delete it just to make sure the build is 100% the same for extra safety.

This is safe to merge because it only touches the tests.
I verified the build folder content is identical to master (just like #10794).

	modified:   src/isomorphic/children/__tests__/ReactChildren-test.js
	modified:   src/isomorphic/classic/element/__tests__/ReactElement-test.js
	modified:   src/renderers/__tests__/EventPluginHub-test.js
	modified:   src/renderers/__tests__/ReactComponent-test.js
	modified:   src/renderers/__tests__/ReactComponentTreeHook-test.js
	modified:   src/renderers/__tests__/ReactCompositeComponent-test.js
	modified:   src/renderers/__tests__/ReactCompositeComponentState-test.js
	modified:   src/renderers/__tests__/ReactEmptyComponent-test.js
	modified:   src/renderers/__tests__/ReactErrorBoundaries-test.js
	modified:   src/renderers/__tests__/ReactHostOperationHistoryHook-test.js
	modified:   src/renderers/__tests__/ReactMultiChild-test.js
	modified:   src/renderers/__tests__/ReactMultiChildText-test.js
	modified:   src/renderers/__tests__/ReactPerf-test.js
	modified:   src/renderers/__tests__/ReactStatelessComponent-test.js
	modified:   src/renderers/__tests__/ReactUpdates-test.js
	modified:   src/renderers/__tests__/multiple-copies-of-react-test.js
	modified:   src/renderers/__tests__/refs-test.js
	modified:   src/renderers/dom/__tests__/ReactDOMProduction-test.js
	modified:   src/renderers/dom/fiber/__tests__/ReactDOMFiber-test.js
	modified:   src/renderers/dom/fiber/__tests__/ReactDOMFiberAsync-test.js
	modified:   src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
	modified:   src/renderers/dom/shared/__tests__/ReactDOMComponentTree-test.js
	modified:   src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
	modified:   src/renderers/dom/shared/__tests__/ReactDOMTextComponent-test.js
	modified:   src/renderers/dom/shared/__tests__/ReactMount-test.js
	modified:   src/renderers/dom/shared/__tests__/ReactRenderDocument-test.js
	modified:   src/renderers/dom/shared/__tests__/ReactServerRendering-test.js
	modified:   src/renderers/dom/shared/__tests__/ReactServerRenderingBrowser-test.js
	modified:   src/renderers/dom/shared/__tests__/renderSubtreeIntoContainer-test.js
	modified:   src/renderers/dom/shared/wrappers/__tests__/ReactDOMInput-test.js
	modified:   src/renderers/dom/shared/wrappers/__tests__/ReactDOMOption-test.js
	modified:   src/renderers/dom/test/__tests__/ReactTestUtils-test.js
	modified:   src/renderers/shared/__tests__/ReactDOMFrameScheduling-test.js

The next step is in #10797.

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me here too.

@gaearon gaearon force-pushed the remove-stack-again-1.5 branch from d8df7ae to 6328eaa Compare September 27, 2017 16:12
@gaearon gaearon merged commit a947d3f into facebook:master Sep 27, 2017
@gaearon gaearon deleted the remove-stack-again-1.5 branch September 27, 2017 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants