Closed
Conversation
|
Deploy preview ready! Built with commit ecf19b1 |
Contributor
|
It seems that previous workaround doesn't work on the latest react(previous it works on react16-beta.5) Before(react16.-beta.5) it works fine: And I copy the changes of this pr, it still can't work. |
Author
|
@NE-SmallTown I have no issue at all on my environment! what is your environment? try to copy contents of
into but build will give you: |
Contributor
windows7 node-8.4.0 npm-5.4.2
previous the result is and it can work. and now(react latest) can't build.Just like above comment description.
yes.Just like I said before, previous it can work but now it can't.
it fails.Just like I said before, previous it can work but now it can't.
this can make it works.(but I think this is not the solution because you know actually we are using react-beta.5 though the repo is react latest)
after I do the copy, I can use npm run build in the fiber-debugger directory and the build result is correct(the react version in the /packages by building is latest rather beta.5) |
Author
|
@NE-SmallTown did you built react before you try
build of on
whats the output of command on your terminal plz paste it here |
Contributor
No. Sorry, I did build in the fiber-debugger directory yesterday. Now after I run install and build in after do build in the root directory, then I try do install and build in fiber-debugger directory again, it still fails.(I delete the copy from packages folder before this) |
Author
why?! this build we depend on when we try to follow this steps:
|
Contributor
I delete fiber-debugger/node_modules/react rather than packages folder because fiber-debugger/node_modules/react is the copy of packages/react of react-beta.5(you suggest do the copy before to test whether npm start can work if we have react in node_modules) but now we need depend on react@latest. |
Author
|
@NE-SmallTown try and tell me did fiber-debugger started normally |
Author
|
@NE-SmallTown react built successfully on your machine but you have issue in linking react to fiber-debugger fixture |
Contributor
Yes, That's the problem. |
Author
I don't know why the only workaround on my mind right now is to build react then take the output of build from |
Contributor
ahh, I doubt this too. And before(react-beta.5) it works(set NODE_PATH) but now it can't, it's really weird.
Ye, thanks, that's what I suppose to do(maybe I will create a script to do this). So, I don't think the problem we are talking about will become others problem(it seems that that's my computer or environment's fault). So, I would like to see this pr get merged. :) |
mhhegazy
force-pushed
the
windows-build-fix
branch
from
fce2377 to
9c5932d
Compare
Collaborator
|
Don't bother with Fiber debugger, it's not essential. We've recently changed a lot of things. For example Yarn is now required to build. Can you get to work with master? Thanks! |
Author
|
Can you get |
Contributor
|
|
@mhhegazy |
Collaborator
|
I'm sorry for losing track of this again. That file changed—would you mind trying to bring it up to date again? |
Collaborator
|
That’s true. We still use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix window build issue
1 - issue on rollup/rollup-plugin-alias#11: resolved in v1.4.0
2 - windows path separator break string in rollup-plugin-replace
this solve build part of #9540