Use simple invariant in case of missing error codes #11350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11348.
Instead of completely skipping an invariant that doesn't have a code, now just uses the 'development" version of it with the full message. It does, however, keep it wrapped in the condition, just like #11291 did.
Verified by compiling this file:
Before:
(Note
Hello world!is nowhere to be found)After:
Note
Hello world!is there. (And two versions of invariant are bundled, as expected.)Also verified extracting errors still works:
(Note both are codes now, and there's just the prod invariant version bundled.)