Skip to content

Added unit test that would have caught the recent error code transform regression #11356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 3 commits into from
Oct 25, 2017
Merged

Added unit test that would have caught the recent error code transform regression #11356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f9b924
Added an automated test that would have caught the recent error code …
bvaughn Oct 24, 2017
6c93e5b
Renamed dev-expression-with-codes test to replace-invariant-error-codes
bvaughn Oct 24, 2017
1fa3a91
Formatting nit
bvaughn Oct 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...tests__/dev-expression-with-codes-test.js → ...s__/replace-invariant-error-codes-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,13 @@ ${expectedInvariantTransformResult}`
`_prodInvariant('18', 'Foo', 'Bar') : void 0;`
);
});

it('should correctly transform invariants that are not in the error codes map', () => {
compare(
"invariant(condition, 'This is not a real error message.');",
`var _prodInvariant = require('shared/reactProdInvariant');

!condition ? invariant(false, 'This is not a real error message.') : void 0;`
);
});
});