Batch together calls to setState, setProps, etc

[sophiebits]

Based off of @ngavalas's #93. Probably not quite mergeable yet but I wanted to send this out tonight and get some feedback.

The end of ReactUpdates-test.js is probably most illuminating for seeing how this works.

[petehunt]

We should throw this in a separate module that is webworker-safe and supports a better RAF polyfill (@benjamn has a good one)

[sophiebits]

Supposedly setTimeout exists in a web worker, but I just realized that this reference to window will probably fail. Happy to use a polyfill if one exists.

[petehunt]

Just splitting it out into a separate module is fine for now. Him or I can drop his polyfill in there later.

[petehunt]

This appears unused

[petehunt]

@spicyj if you need some help with this lmk and I can stack a commit on top of this or something :) I'm really excited about landing this!

[ashwinb]

@petehunt++ -- i am also very excited for this update.

[yungsters]

👍

[yungsters]

This is great. Along the lines of your TODO, have you considered queueing mounting, also?

[sophiebits]

Going to leave mounting as synchronous for now I think but I need to add a callback to renderComponent because that calls setProps half the time.

[sophiebits]

@petehunt @yungsters @jordwalke Took another pass at it – I like this version a lot better. For now, I'm only batching things together when they're in a block like this:

ReactUpdates.batchedUpdates(function() {
  component.setState(...);
  component.setState(...);
});

This means that the event handlers have batched updates but nothing else does yet. I wrote ReactUpdates such that it should be easy to make this defer using rAF in the future.

[yungsters]

Nit.

if (A &&
    B &&
    C) {

[yungsters]

The revised version makes a ton of sense. I love the direction and agree with the TODO comments. 👍

[sophiebits]

(fixed spacing nits)

[petehunt]

if @yungsters is good, I'm good.

[ngavalas]

Lovin' this.

[yungsters]

Also, forceUpdate.

[sophiebits]

fixed.

[petehunt]

I believe we should try/finally this, right?

[petehunt]

@spicyj looks like you've got a failing test; can you take a look? I tried the naive approach of surrounding with batchedUpdates() but it didn't work.