Update additional tests to use .toWarnDev() matcher#11952
Merged
bvaughn merged 4 commits intofacebook:masterfrom Jan 3, 2018
Merged
Update additional tests to use .toWarnDev() matcher#11952bvaughn merged 4 commits intofacebook:masterfrom
bvaughn merged 4 commits intofacebook:masterfrom
Conversation
Note this test previous had some hacky logic to verify errors were reported against unique line numbers. Since the new matcher doesn't suppor this, I replaced this check with an equivalent (I think) comparison of unique DOM elements (eg div -> span)
bvaughn
changed the title
Contributor
Author
|
This is probably ready to review and merge at any point. I'm still working on the remaining tests, but I can push to a new branch if this one gets merged before I'm done. |
gaearon
approved these changes
Jan 3, 2018
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
I haven't read every line but from skimming it looks good
Collaborator
|
(Also, the rate of deleted lines is nice :-) |
Contributor
Author
Oh yeah 🎉 |
yenshih
pushed a commit
to yenshih/react
that referenced
this pull request
Jan 6, 2018
* Migrated several additional tests to use new .toWarnDev() matcher * Migrated ReactDOMComponent-test to use .toWarnDev() matcher Note this test previous had some hacky logic to verify errors were reported against unique line numbers. Since the new matcher doesn't suppor this, I replaced this check with an equivalent (I think) comparison of unique DOM elements (eg div -> span) * Updated several additional tests to use the new .toWarnDev() matcher * Updated many more tests to use .toWarnDev()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for PR #11786
Update additional unit tests to use
.toWarnDev()instead ofconsolespies and if-DEV conditionals.