Skip to content

Temporarily disable the DevTools auto-profiling behavior #13145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bvaughn wants to merge 1 commit into from
Closed

Temporarily disable the DevTools auto-profiling behavior #13145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-reconciler/src/ReactFiber.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,8 @@ export function createHostRootFiber(isAsync: boolean): Fiber {
// Always collect profile timings when DevTools are present.
// This enables DevTools to start capturing timing at any point–
// Without some nodes in the tree having empty base times.
mode |= ProfileMode;
// TODO (bvaughn) Re-enable as part of PR #13123
// mode |= ProfileMode;
}

return createFiber(HostRoot, null, null, mode);
Expand Down
3 changes: 2 additions & 1 deletion packages/react/src/__tests__/ReactProfilerDevToolsIntegration-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ describe('ReactProfiler DevTools integration', () => {
};
});

it('should auto-Profile all fibers if the DevTools hook is detected', () => {
// TODO (bvaughn) Re-enable as part of PR #13123
xit('should auto-Profile all fibers if the DevTools hook is detected', () => {
const App = ({multiplier}) => {
advanceTimeBy(2);
return (
Expand Down