Skip to content

Adding react is export support #13284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrgurdeep wants to merge 1 commit into from
Closed

Adding react is export support #13284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-is/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@
'use strict';

export * from './src/ReactIs';
export {default} from './src/ReactIs';
Copy link

@pgarciacamou pgarciacamou Jul 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you export it twice, I believe that is what is increasing the size of the build files.

23 changes: 23 additions & 0 deletions packages/react-is/src/ReactIs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,26 @@ export function isPortal(object: any) {
export function isStrictMode(object: any) {
return typeOf(object) === REACT_STRICT_MODE_TYPE;
}

export default {
typeOf,
AsyncMode,
ContextConsumer,
ContextProvider,
Element,
ForwardRef,
Fragment,
Profiler,
Portal,
StrictMode,
isValidElementType,
isAsyncMode,
isContextConsumer,
isContextProvider,
isElement,
isForwardRef,
isFragment,
isProfiler,
isPortal,
isStrictMode,
};