Fix SSR crash on a hasOwnProperty attribute#13303
Merged
gaearon merged 1 commit intofacebook:masterfrom Aug 1, 2018
Merged
Conversation
segoddnja
pushed a commit
to segoddnja/react
that referenced
this pull request
Aug 1, 2018
This was referenced Aug 2, 2018
ghost
mentioned this pull request
This was referenced Nov 1, 2018
This was referenced Mar 14, 2021
This was referenced Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While fixing #13302 we found an issue that can cause an SSR crash if the user has control over an attribute name.
While this situation is likely very uncommon, we've included a fix for this crash in
react-dom@16.4.2that went out today.We did not backport this fix to other minor releases because it's only a crash.