Fix incorrect legacy context for factory components #13441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
approved these changes
Aug 20, 2018
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
Factory components are hard for me to think about for some reason. I think this fix looks okay though! Left a tiny nit about naming, but it's up to you whether you respond to it.
| function getUnmaskedContext( | ||
| workInProgress: Fiber, | ||
| Component: Function, | ||
| didPushOwnContext: boolean, |
Contributor
There was a problem hiding this comment.
nit: The naming of this implies that the Fiber is a context provider when it's actually meant more to reflect which phase the component is in. Maybe we could call it something more meaningful? Even didPushOwnContextIfProvider?
Collaborator
Author
There was a problem hiding this comment.
Sounds good. I couldn't find a name I'd be happy with. Which reflects how messed up this whole thing is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/facebook/react/pull/13397/files#r211260178. Surfaced via internal testing.
I added a regression test.