Skip to content

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Aug 20, 2018

In order to make the changes in this PR work, which in turn unblocks a React FB sync, we need to bump the Raect version. Turns out, the version bump was never committed after the recent 16.4.2 release– so this PR jumps it straight to 16.4.3-alpha.0.

This is a little weird, since we don't typically bump until release time. I'm open to other suggestions if anyone else has a better idea.

@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 20, 2018

I test this by syncing to this PR

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. CI error is weird?

@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 20, 2018

Yeah... I'm not sure what's going on with that CI error. ☹️

@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 20, 2018

CI is backed up b'c Circle's having problems, but I ran the same commands locally and the above change should fix this issue so....

@bvaughn bvaughn merged commit 026aa9c into facebook:master Aug 20, 2018
@bvaughn bvaughn deleted the 16.4.3-alpha-version-bump branch August 20, 2018 21:28
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
* Bumped version to 16.4.3-alpha.0
* Bump react-is peer dep version in react-test-renderer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants