Skip to content

Update Dispatcher.js #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vjeux merged 4 commits into from
May 6, 2014
Merged

Update Dispatcher.js #1480

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31477db
Update Dispatcher.js
volkanunsal May 4, 2014
a7823a3
Update Dispatcher.js
volkanunsal May 4, 2014
c81c07c
Update Dispatcher.js
volkanunsal May 4, 2014
035a648
Update Dispatcher.js
volkanunsal May 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions examples/todomvc-flux/js/dispatcher/Dispatcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,6 @@ var _clearPromises = function() {
_promises = [];
};

/**
* Used below in waitFor().
* @param {number} index The index within the _promises array
*/
var _getPromise = function(index) {
return _promises[index];
};

var Dispatcher = function() {};
Dispatcher.prototype = merge(Dispatcher.prototype, {

Expand Down Expand Up @@ -116,7 +108,9 @@ Dispatcher.prototype = merge(Dispatcher.prototype, {
* A more robust Dispatcher would issue a warning in this scenario.
*/
waitFor: function(/*array*/ promiseIndexes, /*function*/ callback) {
var selectedPromises = promiseIndexes.filter(_getPromise);
var selectedPromises = _promises.filter(function(/*object*/ _, /*number*/ j) {
return promiseIndexes.indexOf(j) !== -1;
});
Promise.all(selectedPromises).then(callback);
}

Expand Down