Fix crash unmounting an empty Portal#14820
Merged
gaearon merged 2 commits intofacebook:masterfrom Feb 11, 2019
Merged
Conversation
This was referenced Feb 11, 2019
sophiebits
approved these changes
Feb 11, 2019
Collaborator
sophiebits
left a comment
sophiebits
left a comment
There was a problem hiding this comment.
More error-prone than I’d like, but I agree with your fix and don’t see a cleaner way to structure it.
This was referenced Aug 12, 2019
This was referenced Aug 20, 2019
This was referenced Aug 27, 2019
This was referenced Sep 1, 2019
This was referenced Sep 20, 2019
Open
[Snyk] Upgrade react-dom from 16.5.2 to 16.9.0
maxiplux/spring-security-react-ant-design-polls-app#3
Open
This was referenced Sep 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14811. Thanks @KhodorAmmar for the repro case.
The bug is that we won't pop the portal if it had no children. So we shouldn't push its container either.