[ESLint] Don't suggest a function as its own dep #15115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
approved these changes
Mar 15, 2019
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
lmao #justjavascriptthings
Collaborator
Author
|
I guess there's still a weird case with circular deps where I'm not sure what's the canonical solution is. But maybe let's wait till someone reports it so that we can see the real code people try to write. |
Details of bundled changes.Comparing: 371bbf3...ea12b0a eslint-plugin-react-hooks
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15113.