-
Notifications
You must be signed in to change notification settings - Fork 50.4k
Event API: Add FocusScope surface
#15487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1ce2329
Event API: various bug fixes
trueadm 9fa75c5
Event API: add FocusScope surface
trueadm 8424eff
Fix conflicts
trueadm 223cfb9
Remove FocusScopeTarget
trueadm 8d9c654
Fix bad line
trueadm 7aff11a
Fix copy+paste bug
trueadm 7704124
Rename case-sensitive files to make build pass
trueadm cb2cae3
Fix Flow type
trueadm 51866af
Handle traversing to next host component
trueadm b03763c
Address feedback
trueadm 6327c00
Add simple tests
trueadm 410a786
Add more testing
trueadm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list is missing a few elements: iframe, embed and
contenteditable.Should this component skip subtrees that have the
inertattribute set on the root?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can deal with
inertin a future PR. It's a bit more involved as what if a parent tree hasinertand its sub-trees have theFocusScope?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that is not straightforward, I guess that
FocusScopeshould noop when an ancestor has theinertattribute i.e. (force) disable trap and restore.I am afraid that, because of portals, React needs to polyfill
inertand can't rely on the native implementation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be pretty great if React polyfilled
inertanyway, as it is only supported in Chrome behind a flag.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WICG have a polyfill https://github.com/WICG/inert. There doesn't seem to be vendor agreement on whether to proceed with this attribute or use a different approach. I don't think we need to be too concerned about it here at this stage