Skip to content

Load external scripts in parallel in JSXTransformer #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zpao merged 3 commits into from
May 27, 2014
Merged

Load external scripts in parallel in JSXTransformer #1583

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0614cfa
Load scripts in parallel
nhunzaker May 18, 2014
b124769
Load in parallel, evaluate linearly as they come in
nhunzaker May 21, 2014
59a9251
Set executed after run
nhunzaker May 21, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 37 additions & 18 deletions vendor/browser-transforms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

'use strict';
var runScripts;
var loadScripts;
var headEl;

var buffer = require('buffer');
Expand Down Expand Up @@ -157,18 +158,49 @@ var load = exports.load = function(url, callback) {
xhr.onreadystatechange = function() {
if (xhr.readyState === 4) {
if (xhr.status === 0 || xhr.status === 200) {
run(xhr.responseText, url);
callback(xhr.responseText, url);
} else {
throw new Error("Could not load " + url);
}
if (callback) {
return callback();
}
}
};
return xhr.send(null);
};

loadScripts = function(scripts) {
var result = scripts.map(function() {
return false;
});
var count = result.length;

var check = function() {
var script, i;

for (i = 0; i < count; i++) {
script = result[i];

if (script && !script.executed) {
run(script.content, script.url);
script.executed = true;
} else if (!script) {
break;
}
};
};

scripts.forEach(function(script, i) {
if (script.src) {
load(script.src, function(content, url) {
result[i] = { executed: false, content: content, url: url };
check();
});
} else {
result[i] = { executed: false, content: script.innerHTML, url: null };
check();
}
});
};

runScripts = function() {
var scripts = document.getElementsByTagName('script');

Expand All @@ -182,20 +214,7 @@ runScripts = function() {

console.warn("You are using the in-browser JSX transformer. Be sure to precompile your JSX for production - http://facebook.github.io/react/docs/tooling-integration.html#jsx");

function tick() {
if (!jsxScripts.length) return;

var script = jsxScripts.shift();

if (script.src) {
load(script.src, tick);
} else {
run(script.innerHTML, null);
tick();
}
}

tick();
loadScripts(jsxScripts);
};

if (typeof window !== "undefined" && window !== null) {
Expand Down