[Flare] Add FocusWithin responder #16152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 424099d...7bfb5bd react-events
Generated by 🚫 dangerJS |
necolas
force-pushed
the
react-events/focus-within
branch
from
7fcece3 to
0d5ff14
Compare
Contributor
|
Does it make sense to use focusIn/focusOut for the new responder? Shane about the code duplication too, the Focus module size is quite a bit bigger than before :/ we can come back to that though. |
trueadm
approved these changes
Jul 17, 2019
Contributor
Author
What do you mean?
It's only 0.2 KB larger gzipped after adding new functionality. |
necolas
force-pushed
the
react-events/focus-within
branch
from
0d5ff14 to
7e2b716
Compare
devongovett
approved these changes
Jul 17, 2019
Contributor
devongovett
left a comment
devongovett
left a comment
There was a problem hiding this comment.
I like this idea. Forcing everything into a single responder proved difficult. Thanks for taking this over btw, and sorry I never came back to the old PR.
| ...(focusWithinVisible && focusWithinVisibleStyles) | ||
| }} | ||
| > | ||
| </Focus> |
Contributor
There was a problem hiding this comment.
Should be </FocusWithin>
FocusWithin is implemented as a separate responder, which keeps both focus responders simple and allows for easier composition of behaviours. Close facebook#15848
necolas
force-pushed
the
react-events/focus-within
branch
from
7e2b716 to
7bfb5bd
Compare
Collaborator
|
Hm. This is the exact use case that I was thinking about for the Focal hooks. What's the use case for this that the useListener hooks wouldn't be sufficient for? |
Contributor
Author
|
In the current design? How are you expecting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FocusWithin is implemented as a separate responder, which keeps both focus
responders simple and allows for easier composition of behaviours.
Demo https://codesandbox.io/s/focuswithin-byl1q
Close #15848