[react-interactions] TabFocus -> FocusManager#16874
Merged
trueadm merged 1 commit intofacebook:masterfrom Sep 24, 2019
Merged
Conversation
trueadm
force-pushed
the
focus-manager
branch
from
e132626 to
4a02451
Compare
Details of bundled changes.Comparing: 8b580a8...5142e7f react-interactions
|
trueadm
force-pushed
the
focus-manager
branch
from
4a02451 to
ed18288
Compare
Add continuePropagation to focus events Remove empty FocusList Remove empty FocusList Remove empty FocusList
trueadm
force-pushed
the
focus-manager
branch
from
ed18288 to
5142e7f
Compare
necolas
approved these changes
Sep 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some key alterations to the
TabFocuscomponent and its tests. It also makes some changes to theFocusWithinevent responder.FocusManagercomponentTabFocustoFocusManager, as this is now a more generic focus handling component, it actually does a job of managing focus within its scope.restoreFocusautoFocuscontainprop tocontainFocusso its consistent with other propsFocusWithinrespondercontinuePropagationto the focus eventonBlurWithinevent (needed forFocusManager)