Skip to content

Allow for custom fallback tags. #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leebyron wants to merge 3 commits into from
Closed

Allow for custom fallback tags. #1742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51bb7e9
Allow for custom fallback tags.
leebyron Jun 26, 2014
a18e5f0
@zpao feedback, using hasOwnProperty
leebyron Jun 26, 2014
03bef18
Fix tests
leebyron Jun 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions vendor/fbtransform/transforms/__tests__/react-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,4 +357,33 @@ describe('react jsx', function() {
expect(() => transform(code)).toThrow();
});

it('should allow custom fallback nodes', function() {
var code = [
'/**',
' * @jsx Custom.XML',
' */',
'<CustomNode>',
' <div />',
' <Component />',
'</CustomNode>'
].join('\n');
var result = [
'/**',
' * @jsx Custom.XML',
' */',
'Custom.XML.CustomNode(null,',
' div(null),',
' Component(null)',
');'
].join('\n');

expect(() => transform(code, {
fallbackTags: {
'Custom.XML': {
CustomNode: true
}
}
}).code).toBe(result);
});

});
9 changes: 8 additions & 1 deletion vendor/fbtransform/transforms/react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,17 @@ function visitReactTag(traverse, object, path, state) {
throw new Error('Namespace tags are not supported. ReactJSX is not XML.');
}

var customFallbackTags = state.g.opts.fallbackTags;
var fallbackTags =
(customFallbackTags &&
customFallbackTags.hasOwnProperty(jsxObjIdent) &&
customFallbackTags[jsxObjIdent]) ||
FALLBACK_TAGS;

// Only identifiers can be fallback tags. XJSMemberExpressions are not.
var isFallbackTag =
nameObject.type === Syntax.XJSIdentifier &&
FALLBACK_TAGS.hasOwnProperty(nameObject.name);
fallbackTags.hasOwnProperty(nameObject.name);

utils.append(isFallbackTag ? jsxObjIdent + '.' : '', state);

Expand Down