Replace react-test.js prelude with a custom prelude for now#177
Closed
benjamn wants to merge 2 commits intofacebook:masterfrom
Closed
Replace react-test.js prelude with a custom prelude for now#177benjamn wants to merge 2 commits intofacebook:masterfrom
benjamn wants to merge 2 commits intofacebook:masterfrom
Conversation
This is far from ideal, but it seems to be the easiest way to expose the
require.dumpCache method for use by require("mock-modules").dumpCache.
Upstream patch that would make this hack unnecessary if accepted:
browserify/browser-pack#16
Member
There was a problem hiding this comment.
We should do our multiline strings the same way in the same file... We should maybe put them in a new file and read them in too...
Contributor
Author
|
Accidentally closed. Confused by GitHub IRC bot. #156 is still open. |
Merged
Contributor
Author
|
Superseded by #193. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is far from ideal, but it seems to be the easiest way to expose the
require.dumpCachemethod for use byrequire("mock-modules").dumpCache.Upstream patch that would make this hack unnecessary if accepted:
browserify/browser-pack#16
cc @jeffmo @zpao