Disable classic features in the modern WWW build

packages/react-dom/src/client/ReactDOM.js

@@ -37,6 +37,7 @@ import {
   attemptHydrationAtCurrentPriority,
   act,
 } from 'react-reconciler/inline.dom';
+import {getIsHydrating} from 'react-reconciler/src/ReactFiberHydrationContext';
 import {createPortal as createPortalImpl} from 'shared/ReactPortal';
 import {canUseDOM} from 'shared/ExecutionEnvironment';
 import {setBatchingImplementation} from 'legacy-events/ReactGenericBatching';
@@ -56,6 +57,7 @@ import ReactVersion from 'shared/ReactVersion';
 import invariant from 'shared/invariant';
 import {
   exposeConcurrentModeAPIs,
+  disableLegacyReactDOMAPIs,
   disableUnstableCreatePortal,
   disableUnstableRenderSubtreeIntoContainer,
   warnUnstableRenderSubtreeIntoContainer,
@@ -133,12 +135,6 @@ function createPortal(
 const ReactDOM: Object = {
   createPortal,
 
-  // Legacy
-  findDOMNode,
-  hydrate,
-  render,
-  unmountComponentAtNode,
-
   unstable_batchedUpdates: batchedUpdates,
 
   flushSync: flushSync,
@@ -166,6 +162,13 @@ const ReactDOM: Object = {
   version: ReactVersion,
 };
 
+if (!disableLegacyReactDOMAPIs) {
+  ReactDOM.findDOMNode = findDOMNode;
+  ReactDOM.hydrate = hydrate;
+  ReactDOM.render = render;
+  ReactDOM.unmountComponentAtNode = unmountComponentAtNode;
+}
+
 if (exposeConcurrentModeAPIs) {
   ReactDOM.createRoot = createRoot;
   ReactDOM.createBlockingRoot = createBlockingRoot;
@@ -179,6 +182,8 @@ if (exposeConcurrentModeAPIs) {
       queueExplicitHydrationTarget(target);
     }
   };
+
+  ReactDOM.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.getIsHydrating = getIsHydrating;
 }
 
 if (!disableUnstableRenderSubtreeIntoContainer) {

packages/react-dom/src/client/ReactDOMFB.js

@@ -7,7 +7,6 @@
  * @flow
  */
 
-import {getIsHydrating} from 'react-reconciler/src/ReactFiberHydrationContext';
 import {addUserTimingListener} from 'shared/ReactFeatureFlags';
 
 import ReactDOM from './ReactDOM';
@@ -26,8 +25,6 @@ Object.assign(
     },
     // Perf experiment
     addUserTimingListener,
-
-    getIsHydrating,
   },
 );
 

packages/react-dom/src/events/forks/EventListener-www.js → packages/react-dom/src/events/forks/EventListener.www-classic.js

@@ -10,7 +10,7 @@
 const EventListenerWWW = require('EventListener');
 
 import typeof * as EventListenerType from '../EventListener';
-import typeof * as EventListenerShimType from './EventListener-www';
+import typeof * as EventListenerShimType from './EventListener.www-classic';
 
 export function addEventBubbleListener(
   element: Element,

packages/react-reconciler/src/ReactFiber.js

@@ -425,7 +425,9 @@ export function createWorkInProgress(
 
     if (__DEV__) {
       // DEV-only fields
-      workInProgress._debugID = current._debugID;
+      if (enableUserTimingAPI) {
+        workInProgress._debugID = current._debugID;
+      }
       workInProgress._debugSource = current._debugSource;
       workInProgress._debugOwner = current._debugOwner;
       workInProgress._debugHookTypes = current._debugHookTypes;
@@ -958,7 +960,9 @@ export function assignFiberPropertiesInDEV(
     target.selfBaseDuration = source.selfBaseDuration;
     target.treeBaseDuration = source.treeBaseDuration;
   }
-  target._debugID = source._debugID;
+  if (enableUserTimingAPI) {
+    target._debugID = source._debugID;
+  }
   target._debugSource = source._debugSource;
   target._debugOwner = source._debugOwner;
   target._debugIsCurrentlyTiming = source._debugIsCurrentlyTiming;

packages/shared/ReactFeatureFlags.js

@@ -114,6 +114,8 @@ export const disableLegacyContext = false;
 // Disables React.createFactory
 export const disableCreateFactory = false;
 
+export const disableLegacyReactDOMAPIs = false;
+
 // Disables children for <textarea> elements
 export const disableTextareaChildren = false;
 

packages/shared/forks/ReactFeatureFlags.native-fb.js

@@ -46,6 +46,7 @@ export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
 export const enableTrainModelFix = true;
 export const enableTrustedTypesIntegration = false;
 export const disableCreateFactory = false;
+export const disableLegacyReactDOMAPIs = false;
 export const disableTextareaChildren = false;
 export const disableMapsAsChildren = false;
 export const disableUnstableRenderSubtreeIntoContainer = false;

packages/shared/forks/ReactFeatureFlags.native-oss.js

@@ -41,6 +41,7 @@ export const enableTrainModelFix = true;
 export const enableTrustedTypesIntegration = false;
 export const enableNativeTargetAsInstance = false;
 export const disableCreateFactory = false;
+export const disableLegacyReactDOMAPIs = false;
 export const disableTextareaChildren = false;
 export const disableMapsAsChildren = false;
 export const disableUnstableRenderSubtreeIntoContainer = false;

packages/shared/forks/ReactFeatureFlags.persistent.js

@@ -41,6 +41,7 @@ export const enableTrainModelFix = true;
 export const enableTrustedTypesIntegration = false;
 export const enableNativeTargetAsInstance = false;
 export const disableCreateFactory = false;
+export const disableLegacyReactDOMAPIs = false;
 export const disableTextareaChildren = false;
 export const disableMapsAsChildren = false;
 export const disableUnstableRenderSubtreeIntoContainer = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.js

@@ -41,6 +41,7 @@ export const enableTrainModelFix = true;
 export const enableTrustedTypesIntegration = false;
 export const enableNativeTargetAsInstance = false;
 export const disableCreateFactory = false;
+export const disableLegacyReactDOMAPIs = false;
 export const disableTextareaChildren = false;
 export const disableMapsAsChildren = false;
 export const disableUnstableRenderSubtreeIntoContainer = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

@@ -39,6 +39,7 @@ export const enableTrainModelFix = true;
 export const enableTrustedTypesIntegration = false;
 export const enableNativeTargetAsInstance = false;
 export const disableCreateFactory = false;
+export const disableLegacyReactDOMAPIs = false;
 export const disableTextareaChildren = false;
 export const disableMapsAsChildren = false;
 export const disableUnstableRenderSubtreeIntoContainer = false;

packages/shared/forks/ReactFeatureFlags.testing.js

@@ -41,6 +41,7 @@ export const enableTrainModelFix = true;
 export const enableTrustedTypesIntegration = false;
 export const enableNativeTargetAsInstance = false;
 export const disableCreateFactory = false;
+export const disableLegacyReactDOMAPIs = false;
 export const disableTextareaChildren = false;
 export const disableMapsAsChildren = false;
 export const disableUnstableRenderSubtreeIntoContainer = false;

packages/shared/forks/ReactFeatureFlags.www.js → packages/shared/forks/ReactFeatureFlags.www-classic.js

@@ -8,7 +8,7 @@
  */
 
 import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
-import typeof * as FeatureFlagsShimType from './ReactFeatureFlags.www';
+import typeof * as FeatureFlagsShimType from './ReactFeatureFlags.www-classic';
 
 // Re-export dynamic flags from the www version.
 export const {
@@ -94,6 +94,8 @@ export const enableNativeTargetAsInstance = false;
 
 export const disableCreateFactory = false;
 
+export const disableLegacyReactDOMAPIs = false;
+
 export const disableTextareaChildren = false;
 
 export const disableMapsAsChildren = false;

packages/shared/forks/ReactFeatureFlags.www-modern.js

@@ -0,0 +1,86 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow
+ */
+
+import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
+import typeof * as FeatureFlagsShimType from './ReactFeatureFlags.www-modern';
+
+// Re-export dynamic flags from the www version.
+export const {
+  debugRenderPhaseSideEffectsForStrictMode,
+  disableInputAttributeSyncing,
+  enableTrustedTypesIntegration,
+  deferPassiveEffectCleanupDuringUnmount,
+  warnAboutShorthandPropertyCollision,
+} = require('ReactFeatureFlags');
+
+export let enableUserTimingAPI = false;
+
+export const enableProfilerTimer = __PROFILE__;
+export const enableSchedulerTracing = __PROFILE__;
+export const enableSchedulerDebugging = true;
+
+export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
+export const warnAboutDeprecatedLifecycles = true;
+export const disableLegacyContext = true;
+export const warnAboutStringRefs = false;
+export const warnAboutDefaultPropsOnFunctionComponents = false;
+export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
+
+export const enableTrainModelFix = true;
+
+export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;
+
+export const enableSuspenseServerRenderer = true;
+export const enableSelectiveHydration = true;
+
+export const enableChunksAPI = __EXPERIMENTAL__;
+
+export const disableJavaScriptURLs = true;
+
+export function addUserTimingListener() {
+  throw new Error('Not implemented.');
+}
+
+export const enableDeprecatedFlareAPI = true;
+
+export const enableFundamentalAPI = false;
+
+export const enableScopeAPI = true;
+
+export const enableJSXTransformAPI = true;
+
+export const warnAboutUnmockedScheduler = true;
+
+export const enableSuspenseCallback = true;
+
+export const flushSuspenseFallbacksInTests = true;
+
+export const enableNativeTargetAsInstance = false;
+
+export const disableCreateFactory = false;
+
+export const disableLegacyReactDOMAPIs = true;
+
+export const disableTextareaChildren = true;
+
+export const disableMapsAsChildren = true;
+
+export const disableUnstableRenderSubtreeIntoContainer = true;
+
+export const warnUnstableRenderSubtreeIntoContainer = false;
+
+export const disableUnstableCreatePortal = true;
+
+export const isTestEnvironment = false;
+
+// Flow magic to verify the exports of this file match the original version.
+// eslint-disable-next-line no-unused-vars
+type Check<_X, Y: _X, X: Y = _X> = null;
+// eslint-disable-next-line no-unused-expressions
+(null: Check<FeatureFlagsShimType, FeatureFlagsType>);