Add regression tests where sync render causes later concurrent render to expire soon #18608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only reset
currentEventTimewhen we start concurrent render. SocurrentEventTimeis retained after sync render. That may make later concurrent render expire soon if enough time has elapsed since the last assignment tocurrentEventTime.I've thought about resetting
currentEventTimeinensureRootIsScheduledwhen there's nothing to work on the root. But that breaks the test belowreact/packages/react-reconciler/src/__tests__/ReactExpiration-test.js
Lines 111 to 113 in 9620324