Skip to content

Conversation

@jddxf
Copy link
Contributor

@jddxf jddxf commented Apr 14, 2020

Currently we only reset currentEventTime when we start concurrent render. So currentEventTime is retained after sync render. That may make later concurrent render expire soon if enough time has elapsed since the last assignment to currentEventTime.

I've thought about resetting currentEventTime in ensureRootIsScheduled when there's nothing to work on the root. But that breaks the test below

it(
'two updates of like priority in the same event always flush within the ' +
"same batch, even if there's a sync update in between",

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e245fe0:

Sandbox Source
misty-violet-2dhtr Configuration

@sizebot
Copy link

sizebot commented Apr 14, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against e245fe0

@sizebot
Copy link

sizebot commented Apr 14, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against e245fe0

@jddxf jddxf changed the title Add a failing test for #17911 Add failing tests where sync render causes later concurrent render to expire soon Apr 19, 2020
@gaearon gaearon changed the title Add failing tests where sync render causes later concurrent render to expire soon Add regression tests where sync render causes later concurrent render to expire soon Jun 30, 2020
@gaearon
Copy link
Collaborator

gaearon commented Jun 30, 2020

This seems to pass now. I'll merge.

@gaearon gaearon merged commit fa32cf2 into facebook:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants