getModifierState should always return a boolean #1865
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Rebased |
Member
There was a problem hiding this comment.
Will keyProp ever be undefined?
It was pointed out that this was not a very good question...
return keyProp ? !!nativeEvent[keyProp] : false reads a bit better, lets do that. (This comment stolen from @spicyj)
Collaborator
There was a problem hiding this comment.
This is correct as-is, but keyProp ? !!nativeEvent[keyProp] : false might be clearer.
Contributor
|
you missed a semicolon |
zpao
added a commit
that referenced
this pull request
Jul 23, 2014
getModifierState should always return a boolean
Member
Contributor
Author
|
@zpao OK great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard says it returns a boolean and this is a simple enough fix.