Don't initialize reconcile transaction on server #1870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...when calling setState from within a componentWillMount. Fixes facebook#1866. Test Plan: jest
Member
There was a problem hiding this comment.
var allUnmounted = dirtyComponents.some((dC) => dc.isMounted()) (that should break out early).
Let's not do that this second so we can move fast, but it's so pretty and short :)
Collaborator
Author
There was a problem hiding this comment.
I thought of it and figured that might be slower.
zpao
added a commit
that referenced
this pull request
Jul 18, 2014
Don't initialize reconcile transaction on server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...when calling setState from within a componentWillMount. Fixes #1866.
Test Plan: jest