Skip to content

Conversation

@gaearon
Copy link
Collaborator

@gaearon gaearon commented Jul 1, 2020

This test is bizarre. I wanted to delete it but meh, it's still a bit useful. So I just removed internal usage.

@gaearon gaearon requested a review from trueadm July 1, 2020 14:53
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 1, 2020
@@ -159,47 +126,6 @@ describe('ReactBrowserEventEmitter', () => {
container = null;
});

it('should store a listener correctly', () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh on these.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8e99618:

Sandbox Source
wizardly-browser-rtc24 Configuration

@sizebot
Copy link

sizebot commented Jul 1, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 8e99618

@sizebot
Copy link

sizebot commented Jul 1, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 8e99618

@gaearon gaearon merged commit 5707eeb into facebook:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants