react-rails gem #233
Closed
react-rails gem #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
FWIW, I'm definitely going to pull this into its own repo. Hopefully today or tomorrow. |
Contributor
|
That would be great! |
Member
Author
|
Pulled this out into https://github.com/facebook/react-rails (see more: http://facebook.github.io/react/blog/2013/07/30/use-react-and-jsx-in-ruby-on-rails.html) |
Closed
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Aug 13, 2019
Start using @babel/preset-env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231
There's still a bunch of work to do, but the important things pretty much just work!
This depends on a couple things, namely that we release a react-source v0.4.1 with #217. I built that locally and installed it so I could test.
This is another thing that I would like to pull out of the react repo and publish independently, but for the time being this lets us move fast. I may actually just do that before this is ready to merge in anyway...