Closed
Conversation
|
Comparing: 0fba3ec...5c66252 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
josephsavona
reviewed
Oct 4, 2023
| } | ||
|
|
||
| const root = ReactTestRenderer.create(<Parent />); | ||
| expect(root.toJSON()).toEqual('_selected_all_filters_'); |
Member
There was a problem hiding this comment.
wouldn't the expected output be a <div>Selected filters: ...</div> or similar?
Member
Author
There was a problem hiding this comment.
Simplified it, it should basically hit the selectedFilters == null condition and set it to the constant string
575bf63 to
1818d14
Compare
1818d14 to
98b0b51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interestingly this only seems to fail in ReactTestRenderer, in the codesandbox it correctly shows the right value
https://codesandbox.io/s/unruffled-platform-95l8w7?file=/src/App.js