fix[ci/build]: remove preserve annotation for fb bundles#27668
Closed
hoxyq wants to merge 1 commit intofacebook:mainfrom
Closed
fix[ci/build]: remove preserve annotation for fb bundles#27668hoxyq wants to merge 1 commit intofacebook:mainfrom
hoxyq wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Comparing: 52d542a...367616e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Contributor
Author
|
Should be fixed in #27671. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haste is not happy about
@preserveannotation. Partially migrating to@licenseannotation:@preserveannotation.@licenseannotation will be stripped.@preserve, so we use only one annotation for all wrappers and not keeping it, which works only if its stripped.https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#license-preserve-description
Tested by inspecting headers of generated artifacts in
build/facebook-wwwandbuild/facebook-react-native.