Skip to content

compiler: Add todo for getter/setter syntax#29592

Merged
josephsavona merged 1 commit intogh/josephsavona/17/basefrom
gh/josephsavona/17/head
May 29, 2024
Merged

compiler: Add todo for getter/setter syntax#29592
josephsavona merged 1 commit intogh/josephsavona/17/basefrom
gh/josephsavona/17/head

Conversation

@josephsavona
Copy link
Copy Markdown
Member

@josephsavona josephsavona commented May 25, 2024

Stack from ghstack (oldest at bottom):

We were missing a check that ObjectMethods are not getters or setters. In our experience this is pretty rare within React components and hooks themselves, so let's start with a todo.

Closes #29586

We were missing a check that ObjectMethods are not getters or setters. In our experience this is pretty rare within React components and hooks themselves, so let's start with a todo.

Closes #29586

[ghstack-poisoned]
@vercel
Copy link
Copy Markdown

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 9:29pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 25, 2024
josephsavona added a commit that referenced this pull request May 25, 2024
We were missing a check that ObjectMethods are not getters or setters. In our experience this is pretty rare within React components and hooks themselves, so let's start with a todo.

Closes #29586

ghstack-source-id: 03c6cce
Pull Request resolved: #29592
@react-sizebot
Copy link
Copy Markdown

Comparing: b078c81...9bd33c9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 496.04 kB 496.04 kB = 88.77 kB 88.77 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 500.84 kB 500.84 kB = 89.46 kB 89.46 kB
facebook-www/ReactDOM-prod.classic.js = 593.48 kB 593.48 kB = 104.38 kB 104.38 kB
facebook-www/ReactDOM-prod.modern.js = 569.87 kB 569.87 kB = 100.77 kB 100.77 kB
test_utils/ReactAllWarnings.js Deleted 63.82 kB 0.00 kB Deleted 15.95 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 63.82 kB 0.00 kB Deleted 15.95 kB 0.00 kB

Generated by 🚫 dangerJS against 9bd33c9

@josephsavona
Copy link
Copy Markdown
Member Author

Note that #29593 shows why it isn't safe to just enable support for get/set syntax today (not without assuming that developers follow the rules, at least).

@josephsavona josephsavona merged commit 9bd33c9 into gh/josephsavona/17/base May 29, 2024
josephsavona added a commit that referenced this pull request May 29, 2024
We were missing a check that ObjectMethods are not getters or setters. In our experience this is pretty rare within React components and hooks themselves, so let's start with a todo.

Closes #29586

ghstack-source-id: 03c6cce
Pull Request resolved: #29592
@josephsavona josephsavona deleted the gh/josephsavona/17/head branch May 29, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Component: React Compiler React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants