Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/browser/ui/ReactMount.js
Original file line number Diff line number Diff line change
Expand Up @@ -465,18 +465,22 @@ var ReactMount = {
}

var reactRootElement = getReactRootElementInContainer(container);
var containerHasReactMarkup =
reactRootElement && ReactMount.isRenderedByReact(reactRootElement);
var containerHasReactMarkup = (
reactRootElement &&
!reactRootElement.nextSibling &&
ReactMount.isRenderedByReact(reactRootElement)
);

if (__DEV__) {
if (!containerHasReactMarkup || reactRootElement.nextSibling) {
if (!prevComponent && reactRootElement && reactRootElement.nextSibling) {
var rootElementSibling = reactRootElement;
while (rootElementSibling) {
if (ReactMount.isRenderedByReact(rootElementSibling)) {
console.warn(
'render(): Target node has markup rendered by React, but there ' +
'are unrelated nodes as well. This is most commonly caused by ' +
'white-space inserted around server-rendered markup.'
'are unrelated nodes as well. The markup rendered by React has ' +
'not been reused. This is most commonly caused by white-space ' +
'inserted around server-rendered markup.'
);
break;
}
Expand Down
33 changes: 33 additions & 0 deletions src/browser/ui/__tests__/ReactMount-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,12 @@ describe('ReactMount', function() {
console.warn = mocks.getMockFunction();
ReactMount.render(<div />, container);
expect(console.warn.mock.calls.length).toBe(1);

container.innerHTML = React.renderToString(<div />);

console.warn = mocks.getMockFunction();
ReactMount.render(<div />, container);
expect(console.warn.mock.calls.length).toBe(0);
});

it('should not warn if mounting into non-empty node', function() {
Expand All @@ -144,4 +150,31 @@ describe('ReactMount', function() {
ReactMount.render(<div />, container);
expect(console.warn.mock.calls.length).toBe(0);
});

it('should reuse if mounting into rendered markup', function() {
var container = document.createElement('container');
container.innerHTML = React.renderToString(<div />);

var renderedNode = container.firstChild;
ReactMount.render(<div />, container);
expect(container.firstChild).toBe(renderedNode);
});

it('should not reuse if mounting into dirty rendered markup', function() {
var container = document.createElement('container');
var renderedMarkup = React.renderToString(<div />);
var renderedNode;

container.innerHTML = renderedMarkup + ' ';

renderedNode = container.firstChild;
ReactMount.render(<div />, container);
expect(container.firstChild).not.toBe(renderedNode);

container.innerHTML = ' ' + renderedMarkup;

renderedNode = container.firstChild;
ReactMount.render(<div />, container);
expect(container.firstChild).not.toBe(renderedNode);
});
});