Skip to content

[compiler][ez] Rename disableMemoizationForDebugging to just disableMemoization #30191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mvitousek wants to merge 9 commits into from
Closed

[compiler][ez] Rename disableMemoizationForDebugging to just disableMemoization #30191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1ed7cb0
[compiler][ez] Rename disableMemoizationForDebugging to just disableM…
mvitousek Jul 2, 2024
ea23260
Update on "[compiler][ez] Rename disableMemoizationForDebugging to ju…
mvitousek Jul 2, 2024
c3e34b6
Update on "[compiler][ez] Rename disableMemoizationForDebugging to ju…
mvitousek Jul 18, 2024
753b7c9
Update on "[compiler][ez] Rename disableMemoizationForDebugging to ju…
mvitousek Jul 18, 2024
33b05f5
Update on "[compiler][ez] Rename disableMemoizationForDebugging to ju…
mvitousek Jul 18, 2024
541a905
Update on "[compiler][ez] Rename disableMemoizationForDebugging to ju…
mvitousek Jul 18, 2024
ec93a6c
Update on "[compiler][ez] Rename disableMemoizationForDebugging to ju…
mvitousek Jul 26, 2024
ead8e52
Update on "[compiler][ez] Rename disableMemoizationForDebugging to ju…
mvitousek Jul 26, 2024
8c3c13f
Update on "[compiler][ez] Rename disableMemoizationForDebugging to ju…
mvitousek Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ const EnvironmentConfigSchema = z.object({
* @enablePreserveExistingManualUseMemo, because otherwise memoization in the
* original source will be disabled as well.
*/
disableMemoizationForDebugging: z.boolean().default(false),
disableMemoization: z.boolean().default(false),

/**
* When true, rather using memoized values, the compiler will always re-compute
Expand Down Expand Up @@ -778,7 +778,7 @@ export class Environment {
preserveManualMemo(): boolean {
return (
this.config.enablePreserveExistingManualUseMemo ||
this.config.disableMemoizationForDebugging ||
this.config.disableMemoization ||
this.config.enableChangeDetection != null
);
}
Expand Down
4 changes: 2 additions & 2 deletions compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ function codegenReactiveScope(
);
}

if (cx.env.config.disableMemoizationForDebugging) {
if (cx.env.config.disableMemoization) {
testCondition = t.logicalExpression(
'||',
testCondition,
Expand Down Expand Up @@ -736,7 +736,7 @@ function codegenReactiveScope(
t.variableDeclarator(t.identifier(loadNameStr), genSlot()),
]),
);
if (!cx.env.config.disableMemoizationForDebugging) {
if (!cx.env.config.disableMemoization) {
restoreOldValueStatements.push(
t.expressionStatement(
t.assignmentExpression("=", t.identifier(nameStr), restoredValue)
Expand Down
4 changes: 2 additions & 2 deletions ...act-compiler/src/__tests__/fixtures/compiler/nomemo-and-change-detect.expect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## Input

```javascript
// @disableMemoizationForDebugging @enableChangeDetection
// @disableMemoization @enableChangeDetection
import { useMemo } from "react";

function Component(props) {
Expand All @@ -28,7 +28,7 @@ export const FIXTURE_ENTRYPOINT = {

```javascript
import { $structuralCheck } from "react-compiler-runtime";
import { c as _c } from "react/compiler-runtime"; // @disableMemoizationForDebugging @enableChangeDetection
import { c as _c } from "react/compiler-runtime"; // @disableMemoization @enableChangeDetection
import { useMemo } from "react";

function Component(props) {
Expand Down
2 changes: 1 addition & 1 deletion ...s/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/nomemo-and-change-detect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// @disableMemoizationForDebugging @enableChangeDetection
// @disableMemoization @enableChangeDetection
import { useMemo } from "react";

function Component(props) {
Expand Down
4 changes: 2 additions & 2 deletions ...piler/src/__tests__/fixtures/compiler/useMemo-simple-preserved-nomemo.expect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## Input

```javascript
// @disableMemoizationForDebugging
// @disableMemoization
import {useMemo} from 'react';

function Component({a}) {
Expand All @@ -21,7 +21,7 @@ export const FIXTURE_ENTRYPOINT = {
## Code

```javascript
import { c as _c } from "react/compiler-runtime"; // @disableMemoizationForDebugging
import { c as _c } from "react/compiler-runtime"; // @disableMemoization
import { useMemo } from "react";

function Component(t0) {
Expand Down
2 changes: 1 addition & 1 deletion ...-plugin-react-compiler/src/__tests__/fixtures/compiler/useMemo-simple-preserved-nomemo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// @disableMemoizationForDebugging
// @disableMemoization
import {useMemo} from 'react';

function Component({a}) {
Expand Down