Remove enableAsyncActions#31757
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: fb12845d779667b35cc7f44eee6bea47f4db72ba...47a2df59fa1867d821abddcc552c4ffc10c37f89 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
rickhanlonii
force-pushed
the
rh/rm-ff-asyncactions
branch
from
4b4420e to
2fe57eb
Compare
rickhanlonii
force-pushed
the
rh/rm-ff-asyncactions
branch
from
2fe57eb to
038fdfb
Compare
# Conflicts: # packages/react-server/src/ReactFizzHooks.js
| useHostTransitionStatus: (unsupportedHook: any), | ||
| useOptimistic: (unsupportedHook: any), | ||
| useFormState: (unsupportedHook: any), | ||
| useActionState: (unsupportedHook: any), |
There was a problem hiding this comment.
@sebmarkbage could you double check this? I don't think the flight dispatcher had these hooks defined before as unsupported.
There was a problem hiding this comment.
Yea, it doesn't really need it because the outer export shouldn't be available in that environment. This is just protecting against a misconfigured environment but it's good to have that backup so you know why.
| if (typeof Dispatcher.useActionState === 'function') { | ||
| // This type check is for Flow only. | ||
| Dispatcher.useActionState((s: mixed, p: mixed) => s, null); | ||
| } |
There was a problem hiding this comment.
This one is used by react-devtools on older versions of React so this check must still remain.
There was a problem hiding this comment.
Got it, so the comment about only being for Flow is wrong haha
There was a problem hiding this comment.
Actually no I'm wrong. This is the local dispatcher. Not the dispatcher ref.
There was a problem hiding this comment.
Confirmed that this is the internal dispatcher, not the one in devtools
Based off #31757 This has landed everywhere.
4 participants
Based on #31756
This is landed everywhere