Skip to content

Conversation

@jimfb
Copy link
Contributor

@jimfb jimfb commented Feb 18, 2015

Added webcomponents.js and a simple unit test verifying a document fragment as a valid React container.

@jimfb jimfb changed the title Added webcomponents.js and a simple unit test verifying a document fragment as a valid React contain Added webcomponents.js and a simple unit test verifying a document fragment as a valid React container Feb 18, 2015
@jimfb jimfb force-pushed the webcomponent-to-vendor-thirdparty branch from 6d2f283 to 5f605cc Compare February 18, 2015 00:58
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the ; in this case? (just curious).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue, it came with a copy-paste from ReactWebWorker-test, I suppose I was just being consistent :). Fixed :).

@jimfb jimfb force-pushed the webcomponent-to-vendor-thirdparty branch from 292bead to 1205929 Compare March 16, 2015 23:37
@jimfb
Copy link
Contributor Author

jimfb commented Mar 16, 2015

Rebased, fixed trivial merge conflict.

jimfb added a commit that referenced this pull request Mar 16, 2015
Added webcomponents.js and a simple unit test verifying a document fragment as a valid React container
@jimfb jimfb merged commit 87e14c5 into facebook:master Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants